iCloud hasn’t exactly had the best week.
That doesn’t mean you shouldn’t use two-factor authentication, of course.
It still protects you to a certain degree.
Apple’s Two Factor Authentication Doesn’t Protect iCloud Backups or Photo Streams| TechCrunch